250307.1 · b989f98033b7eb061e875b8137d670d8a20c259b
refactor: use const to replace var (#593)
reading declarations
@@ -98,7 +98,7 @@ in `build/Release/`. You can now use the binary addon in a Node project `hello.js` by pointing `require` to the recently built `hello.node` module: - var addon = require('./build/Release/hello');+ const addon = require('./build/Release/hello'); console.log(addon.hello()); // 'world' @@ -175,7 +175,7 @@ function calls and return a result. This is the main and only needed source You can test it with the following JavaScript snippet: - var addon = require('./build/Release/addon');+ const addon = require('./build/Release/addon'); console.log( 'This should be eight:', addon.add(3,5) ); @@ -215,7 +215,7 @@ adding the function as a property of `exports`. To test it run the following JavaScript snippet: - var addon = require('./build/Release/addon');+ const addon = require('./build/Release/addon'); addon(function(msg){ console.log(msg); // 'hello world'@@ -251,10 +251,10 @@ the string passed to `createObject()`: To test it in JavaScript: - var addon = require('./build/Release/addon');+ const addon = require('./build/Release/addon'); - var obj1 = addon('hello');- var obj2 = addon('world');+ const obj1 = addon('hello');+ const obj2 = addon('world'); console.log(obj1.msg+' '+obj2.msg); // 'hello world' @@ -293,9 +293,9 @@ wraps a C++ function: To test: - var addon = require('./build/Release/addon');+ const addon = require('./build/Release/addon'); - var fn = addon();+ const fn = addon(); console.log(fn()); // 'hello world' @@ -398,9 +398,9 @@ prototype: Test it with: - var addon = require('./build/Release/addon');+ const addon = require('./build/Release/addon'); - var obj = new addon.MyObject(10);+ const obj = new addon.MyObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13@@ -411,9 +411,9 @@ Test it with: This is useful when you want to be able to create native objects without explicitly instantiating them with the `new` operator in JavaScript, e.g. - var obj = addon.createObject();+ const obj = addon.createObject(); // instead of:- // var obj = new addon.Object();+ // const obj = new addon.Object(); Let's register our `createObject` method in `addon.cc`: @@ -528,14 +528,14 @@ The implementation is similar to the above in `myobject.cc`: Test it with: - var createObject = require('./build/Release/addon');+ const createObject = require('./build/Release/addon'); - var obj = createObject(10);+ const obj = createObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13 - var obj2 = createObject(20);+ const obj2 = createObject(20); console.log( obj2.plusOne() ); // 21 console.log( obj2.plusOne() ); // 22 console.log( obj2.plusOne() ); // 23@@ -662,10 +662,10 @@ The implementation of `myobject.cc` is similar as before: Test it with: - var addon = require('./build/Release/addon');+ const addon = require('./build/Release/addon'); - var obj1 = addon.createObject(10);- var obj2 = addon.createObject(20);- var result = addon.add(obj1, obj2);+ const obj1 = addon.createObject(10);+ const obj2 = addon.createObject(20);+ const result = addon.add(obj1, obj2); console.log(result); // 30
src/1-getting-started/1_hello_world/nan/hello.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('hello');+const addon = require('bindings')('hello'); console.log(addon.hello()); // 'world'
src/1-getting-started/1_hello_world/napi/hello.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('hello');+const addon = require('bindings')('hello'); console.log(addon.hello()); // 'world'
src/1-getting-started/1_hello_world/node-addon-api-addon-class/hello.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('hello');+const addon = require('bindings')('hello'); console.log(addon.hello()); // 'world'
src/1-getting-started/1_hello_world/node-addon-api/hello.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('hello');+const addon = require('bindings')('hello'); console.log(addon.hello()); // 'world'
src/1-getting-started/2_function_arguments/nan/addon.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('addon.node')+const addon = require('bindings')('addon.node') console.log('This should be eight:', addon.add(3, 5))
src/1-getting-started/2_function_arguments/napi/addon.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('addon.node')+const addon = require('bindings')('addon.node') console.log('This should be eight:', addon.add(3, 5))
src/1-getting-started/2_function_arguments/node-addon-api/addon.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('addon.node')+const addon = require('bindings')('addon.node') console.log('This should be eight:', addon.add(3, 5))
src/1-getting-started/3_callbacks/nan/addon.js
@@ -1,4 +1,4 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); addon(function(msg){ console.log(msg); // 'hello world'
src/1-getting-started/3_callbacks/napi/addon.js
@@ -1,4 +1,4 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); addon(function(msg){ console.log(msg); // 'hello world'
src/1-getting-started/3_callbacks/node-addon-api/addon.js
@@ -1,4 +1,4 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); addon(function(msg){ console.log(msg); // 'hello world'
src/1-getting-started/4_object_factory/nan/addon.js
@@ -1,5 +1,5 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj1 = addon('hello');-var obj2 = addon('world');+const obj1 = addon('hello');+const obj2 = addon('world'); console.log(obj1.msg+' '+obj2.msg); // 'hello world'
src/1-getting-started/4_object_factory/napi/addon.js
@@ -1,5 +1,5 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj1 = addon('hello');-var obj2 = addon('world');+const obj1 = addon('hello');+const obj2 = addon('world'); console.log(obj1.msg+' '+obj2.msg); // 'hello world'
src/1-getting-started/4_object_factory/node-addon-api/addon.js
@@ -1,5 +1,5 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj1 = addon('hello');-var obj2 = addon('world');+const obj1 = addon('hello');+const obj2 = addon('world'); console.log(obj1.msg+' '+obj2.msg); // 'hello world'
src/1-getting-started/5_function_factory/nan/addon.js
@@ -1,4 +1,4 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var fn = addon();+const fn = addon(); console.log(fn()); // 'hello world'
src/1-getting-started/5_function_factory/napi/addon.js
@@ -1,4 +1,4 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var fn = addon();+const fn = addon(); console.log(fn()); // 'hello world'
src/1-getting-started/5_function_factory/node-addon-api/addon.js
@@ -1,4 +1,4 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var fn = addon();+const fn = addon(); console.log(fn()); // 'hello world'
src/1-getting-started/6_object_wrap/nan/addon.js
@@ -1,6 +1,6 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj = new addon.MyObject(10);+const obj = new addon.MyObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13@@ -8,6 +8,6 @@ console.log( obj.plusOne() ); // 13 console.log( obj.multiply().value() ); // 13 console.log( obj.multiply(10).value() ); // 130 -var newobj = obj.multiply(-1);+const newobj = obj.multiply(-1); console.log( newobj.value() ); // -13 console.log( obj === newobj ); // false
src/1-getting-started/6_object_wrap/napi/addon.js
@@ -1,6 +1,6 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj = new addon.MyObject(10);+const obj = new addon.MyObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13@@ -8,6 +8,6 @@ console.log( obj.plusOne() ); // 13 console.log( obj.multiply().value ); // 13 console.log( obj.multiply(10).value ); // 130 -var newobj = obj.multiply(-1);+const newobj = obj.multiply(-1); console.log( newobj.value ); // -13 console.log( obj === newobj ); // false
src/1-getting-started/6_object_wrap/node-addon-api/addon.js
@@ -1,6 +1,6 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj = new addon.MyObject(10);+const obj = new addon.MyObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13@@ -8,6 +8,6 @@ console.log( obj.plusOne() ); // 13 console.log( obj.multiply().value() ); // 13 console.log( obj.multiply(10).value() ); // 130 -var newobj = obj.multiply(-1);+const newobj = obj.multiply(-1); console.log( newobj.value() ); // -13 console.log( obj === newobj ); // false
src/1-getting-started/7_factory_wrap/nan/addon.js
@@ -1,11 +1,11 @@-var createObject = require('bindings')('addon');+const createObject = require('bindings')('addon'); -var obj = createObject(10);+const obj = createObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13 -var obj2 = createObject(20);+const obj2 = createObject(20); console.log( obj2.plusOne() ); // 21 console.log( obj2.plusOne() ); // 22 console.log( obj2.plusOne() ); // 23
src/1-getting-started/7_factory_wrap/napi/addon.js
@@ -1,11 +1,11 @@-var createObject = require('bindings')('addon');+const createObject = require('bindings')('addon'); -var obj = createObject(10);+const obj = createObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13 -var obj2 = createObject(20);+const obj2 = createObject(20); console.log( obj2.plusOne() ); // 21 console.log( obj2.plusOne() ); // 22 console.log( obj2.plusOne() ); // 23
src/1-getting-started/7_factory_wrap/node-addon-api/addon.js
@@ -1,11 +1,11 @@-var createObject = require('bindings')('addon');+const createObject = require('bindings')('addon'); -var obj = createObject(10);+const obj = createObject(10); console.log( obj.plusOne() ); // 11 console.log( obj.plusOne() ); // 12 console.log( obj.plusOne() ); // 13 -var obj2 = createObject(20);+const obj2 = createObject(20); console.log( obj2.plusOne() ); // 21 console.log( obj2.plusOne() ); // 22 console.log( obj2.plusOne() ); // 23
src/2-js-to-native-conversion/8_passing_wrapped/nan/addon.js
@@ -1,7 +1,7 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj1 = addon.createObject(10);-var obj2 = addon.createObject(20);-var result = addon.add(obj1, obj2);+const obj1 = addon.createObject(10);+const obj2 = addon.createObject(20);+const result = addon.add(obj1, obj2); console.log(result); // 30
src/2-js-to-native-conversion/8_passing_wrapped/napi/addon.js
@@ -1,7 +1,7 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj1 = addon.createObject(10);-var obj2 = addon.createObject(20);-var result = addon.add(obj1, obj2);+const obj1 = addon.createObject(10);+const obj2 = addon.createObject(20);+const result = addon.add(obj1, obj2); console.log(result); // 30
src/2-js-to-native-conversion/8_passing_wrapped/node-addon-api/addon.js
@@ -1,7 +1,7 @@-var addon = require('bindings')('addon');+const addon = require('bindings')('addon'); -var obj1 = addon.createObject(10);-var obj2 = addon.createObject(20);-var result = addon.add(obj1, obj2);+const obj1 = addon.createObject(10);+const obj2 = addon.createObject(20);+const result = addon.add(obj1, obj2); console.log(result); // 30
src/2-js-to-native-conversion/object-wrap-demo/node-addon-api/lib/binding.js
@@ -5,7 +5,7 @@ function ObjectWrapDemo(name) { return _addonInstance.greet(str); } - var _addonInstance = new addon.ObjectWrapDemo(name);+ const _addonInstance = new addon.ObjectWrapDemo(name); } module.exports = ObjectWrapDemo;
src/5-async-work/async_pi_estimate/nan/addon.js
@@ -1,5 +1,5 @@-var addon = require('./build/Release/addon');-var calculations = process.argv[2] || 100000000;+const addon = require('./build/Release/addon');+const calculations = process.argv[2] || 100000000; function printResult(type, pi, ms) { console.log(type, 'method:');@@ -10,19 +10,19 @@ function printResult(type, pi, ms) { } function runSync() {- var start = Date.now();+ const start = Date.now(); // Estimate() will execute in the current thread, // the next line won't return until it is finished- var result = addon.calculateSync(calculations);+ const result = addon.calculateSync(calculations); printResult('Sync', result, Date.now() - start); } function runAsync() { // how many batches should we split the work in to?- var batches = process.argv[3] || 16;- var ended = 0;- var total = 0;- var start = Date.now();+ const batches = process.argv[3] || 16;+ let ended = 0;+ let total = 0;+ const start = Date.now(); function done (err, result) { total += result;@@ -35,7 +35,7 @@ function runAsync() { // for each batch of work, request an async Estimate() for // a portion of the total number of calculations- for (var i = 0; i < batches; i++) {+ for (let i = 0; i < batches; i++) { addon.calculateAsync(calculations / batches, done); } }
src/5-async-work/async_pi_estimate/node-addon-api/addon.js
@@ -1,5 +1,5 @@-var addon = require('bindings')('addon');-var calculations = process.argv[2] || 100000000;+const addon = require('bindings')('addon');+const calculations = process.argv[2] || 100000000; function printResult(type, pi, ms) { console.log(type, 'method:');@@ -10,19 +10,19 @@ function printResult(type, pi, ms) { } function runSync() {- var start = Date.now();+ const start = Date.now(); // Estimate() will execute in the current thread, // the next line won't return until it is finished- var result = addon.calculateSync(calculations);+ const result = addon.calculateSync(calculations); printResult('Sync', result, Date.now() - start); } function runAsync() { // how many batches should we split the work in to?- var batches = process.argv[3] || 16;- var ended = 0;- var total = 0;- var start = Date.now();+ const batches = process.argv[3] || 16;+ let ended = 0;+ let total = 0;+ const start = Date.now(); function done (err, result) { total += result;@@ -35,7 +35,7 @@ function runAsync() { // for each batch of work, request an async Estimate() for // a portion of the total number of calculations- for (var i = 0; i < batches; i++) {+ for (let i = 0; i < batches; i++) { addon.calculateAsync(calculations / batches, done); } }
src/8-tooling/build_with_cmake/napi/hello.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('build-napi-with-cmake');+const addon = require('bindings')('build-napi-with-cmake'); console.log(addon.hello()); // 'world'
src/8-tooling/build_with_cmake/node-addon-api/hello.js
@@ -1,3 +1,3 @@-var addon = require('bindings')('build-node-addon-api-with-cmake');+const addon = require('bindings')('build-node-addon-api-with-cmake'); console.log(addon.hello()); // 'world'
website/docs/build-tools/node-pre-gyp.md
@@ -147,10 +147,10 @@ The Node-API header files configure themselves based on the C/C++ symbol `NAPI_V JavaScript code that requires the native code must be updated to dynamically locate the `.node` file. ```-var binary = require('node-pre-gyp');-var path = require('path');-var binding_path = binary.find(path.resolve(path.join(__dirname,'./package.json')));-var binding = require(binding_path);+const binary = require('node-pre-gyp');+const path = require('path');+const binding_path = binary.find(path.resolve(path.join(__dirname,'./package.json')));+const binding = require(binding_path); ``` ## Build