@ 201216.1 · fetching

200626.3 · 5600c1b6b11c1e293cde882bac82fe9d3a6b2584

Merge pull request #1389 from aswild/getenv-segfault

options: fix segfault when TERM or HOME isn't set

reading declarations

src/options.c

@@ -150,7 +150,7 @@ void init_options(void) {     memset(&opts, 0, sizeof(opts));     opts.casing = CASE_DEFAULT;     opts.color = TRUE;-    if (strcmp(term, "dumb") == 0) {+    if (term && !strcmp(term, "dumb")) {         opts.color = FALSE;     }     opts.color_win_ansi = FALSE;@@ -713,8 +713,10 @@ void parse_options(int argc, char **argv, char **base_paths[], char **paths[]) {                 const char *config_home = getenv("XDG_CONFIG_HOME");                 if (config_home) {                     ag_asprintf(&gitconfig_res, "%s/%s", config_home, "git/ignore");-                } else {+                } else if (home_dir) {                     ag_asprintf(&gitconfig_res, "%s/%s", home_dir, ".config/git/ignore");+                } else {+                    gitconfig_res = ag_strdup("");                 }             }             log_debug("global core.excludesfile: %s", gitconfig_res);

tests/empty_environment.t

new file mode 100644@@ -0,0 +1,9 @@+Setup:++  $ . $TESTDIR/setup.sh+  $ printf "hello world\n" >test.txt++Verify ag runs with an empty environment:++  $ env -i $TESTDIR/../ag --noaffinity --nocolor --workers=1 --parallel hello+  test.txt:1:hello world