190920.1 · ec343a444fc88e868c4f3991b5da9f596f5c4b08
Remove taint checks from tests (GH #235)
reading declarations
@@ -7,6 +7,10 @@ Using -w with a pattern that ended with a metacharacter would be slower than it should be because it would skip an optimization. Now it's fixed. (GH #181, #251) +[FIXES]+Fixed test failures that would sometimes happen on Windows machines because+of taint mode. Thanks, Tomasz Konojacki. (GH #235)+ v3.1.1 Sat Aug 31 22:56:10 CDT 2019 ========================================
@@ -2296,6 +2296,7 @@ mailing list. How appropriate to have I<ack>nowledgements! Thanks to everyone who has contributed to ack in any way, including+Tomasz Konojacki, Salomon Smeke, M. Scott Ford, Anders Eriksson,
@@ -1,4 +1,4 @@-#!perl -T+#!perl use 5.010; use warnings;
@@ -686,7 +686,7 @@ sub _record_option_coverage { # strip the command line up until 'ack' is found $command_line =~ s/^.*ack\b//; - $command_line = "$perl -T $record_options $command_line";+ $command_line = "$perl $record_options $command_line"; system $command_line; }@@ -695,7 +695,7 @@ sub _record_option_coverage { shift @command_line; } shift @command_line; # get rid of 'ack' itself- unshift @command_line, $perl, '-T', $record_options;+ unshift @command_line, $perl, $record_options; system @command_line; }
t/ack-1.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
t/ack-c.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
t/ack-column.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-f.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-filetypes.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-h.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-i.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-k.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
t/ack-known-types.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-m.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/ack-o.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
t/ack-proximate.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;@@ -15,14 +15,14 @@ my @SWAMP = qw( t/swamp ); TEST_TYPE: { my @expected = line_split( <<'HERE' ); t/swamp/0:1:#!/usr/bin/perl -w-t/swamp/Makefile.PL:1:#!perl -T+t/swamp/Makefile.PL:1:#!perl t/swamp/options-crlf.pl:1:#!/usr/bin/env perl t/swamp/options.pl:1:#!/usr/bin/env perl-t/swamp/perl-test.t:1:#!perl -T+t/swamp/perl-test.t:1:#!perl t/swamp/perl-without-extension:1:#!/usr/bin/perl -w-t/swamp/perl.cgi:1:#!perl -T-t/swamp/perl.pl:1:#!perl -T-t/swamp/perl.pm:1:#!perl -T+t/swamp/perl.cgi:1:#!perl+t/swamp/perl.pl:1:#!perl+t/swamp/perl.pm:1:#!perl HERE # Reslash the filenames in case we are on Windows.
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
t/ack-v.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/anchored.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl # Make sure beginning-of-line anchor works
t/asp-net-ext.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/basic.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl # This file validates behaviors of specifying files on the command line.
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl # Make sure ack can handle files it can't read.
t/filetype-detection.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl # XXX This test need to include not-forbidden-options, like --sort and --smart-case.
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl # https://github.com/beyondgrep/ack3/issues/192
t/inverted-file-filter.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
t/issue244.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl # https://github.com/beyondgrep/ack2/issues/244
t/issue491.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl =pod
t/issue522.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl # https://github.com/beyondgrep/ack2/issues/522
t/issue562.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl # https://github.com/beyondgrep/ack2/issues/562
t/issue571.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl # https://github.com/beyondgrep/ack2/issues/571
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use strict; use warnings;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
t/zero.t
@@ -1,4 +1,4 @@-#!perl -T+#!perl =pod
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;
@@ -1,4 +1,4 @@-#!perl -T+#!perl # Checks that we are not using core C<die> or C<warn> except in very specific places. # Same with C<mkdir> and C<chdir>.
@@ -1,4 +1,4 @@-#!perl -T+#!perl use warnings; use strict;