261023.2 · cff2849fd49557c2184a3b2858469a2bfbe20753
index: revert indexing additions
I think that this was probably a failed experiment. I suspect that it is too difficult to retro-fit indexing on top of ripgrep. Among other issues, one of the main problems is knowing what to index. Surely most cases want to use ripgrep's defaults (i.e., its "smart" filtering), but some use cases might want to ignore part or all of ripgrep's filtering. Reconciling this with ripgrep's existing command line structure in a user friendly way seems fraught.
Ref #1497
reading declarations
Changes to crates/core/flags/mod.rs. All files
@@ -47,9 +47,6 @@ mod hiargs; mod lowargs; mod parse; -const INDEXING_NOT_SUPPORTED: &'static str =- "Indexing is not supported in this build of ripgrep.";- /// A trait that encapsulates the definition of an optional flag for ripgrep. /// /// This trait is meant to be used via dynamic dispatch. Namely, the `defs`@@ -208,9 +205,6 @@ enum Category { /// lines, and instead just print the total count of matches for each file /// searched. OutputModes,- /// Flags related to indexing. This section includes flags both for- /// searching an index and updating an index.- Indexing, /// Flags related to logging behavior such as emitting non-fatal error /// messages or printing search statistics. Logging,@@ -232,7 +226,6 @@ impl Category { Category::Filter => "filter", Category::Output => "output", Category::OutputModes => "output-modes",- Category::Indexing => "indexing", Category::Logging => "logging", Category::OtherBehaviors => "other-behaviors", }